Skip to content

pythonPackages.unittestCheckHook: align to docs, support dynamic flags in preCheck script#191948

Closed
impl wants to merge 2 commits intoNixOS:stagingfrom
impl:python-unittest-hook
Closed

pythonPackages.unittestCheckHook: align to docs, support dynamic flags in preCheck script#191948
impl wants to merge 2 commits intoNixOS:stagingfrom
impl:python-unittest-hook

Conversation

@impl
Copy link
Member

@impl impl commented Sep 19, 2022

Description of changes

In the docs, the flags for the unittestCheckHook are described as belonging in unittestFlags, but it seems that the hook script was expecting them to be set as unittestFlagsArray. In stdenv at least it seems that the *Array variants are used for dynamically configuring the flags in a pre* script, e.g. preCheck = "unittestFlagsArray+=(--foo)", so this PR aligns the script behavior to the docs/stdenv instead of just updating the docs to match the current implementation.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Sep 19, 2022
@impl impl requested a review from winterqt September 19, 2022 17:16
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Sep 19, 2022
@impl impl force-pushed the python-unittest-hook branch from f46e62f to 46cf3da Compare September 19, 2022 18:25
@impl impl marked this pull request as ready for review September 19, 2022 18:27
winterqt
winterqt requested changes Sep 19, 2022
View reviewed changes
Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so this PR aligns the script behavior to the docs/stdenv instead of just updating the docs to match the current implementation.

Please do this instead. It looks like I forgot to change the docs after #185430 (comment) -- unittestFlagsArray is correct (for now, anyways).

@impl
Copy link
Member Author

impl commented Sep 19, 2022

so this PR aligns the script behavior to the docs/stdenv instead of just updating the docs to match the current implementation.

Please do this instead. It looks like I forgot to change the docs after #185430 (comment) -- unittestFlagsArray is correct (for now, anyways).

Ah ok, will do! I'll open a new PR against master since it won't require a mass-rebuild then. Thanks!

@impl impl closed this Sep 19, 2022
@impl impl deleted the python-unittest-hook branch September 19, 2022 18:47
@impl impl mentioned this pull request Sep 19, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@winterqt winterqt winterqt requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@impl @winterqt